@joevitus - regarding the lines in the book about her voice: fair enough point. In all honesty, I did not remember that being a plot point.
That comment came from my experience having been blown away by Sheridan Smith’s performance in London, and Smith’s vocals were only passable.
I see your point about the real Fanny vs. the musical Fanny, and how that plays into the “talent is beauty” theme. But I’m not sure I agree with your interpretation (aside from the specific references to her voice, which I conceded above). To say that “the real Fanny Brice’s talent was humor, and the musical Fanny’s talent is singing” is simply an untrue dichotomy. Fanny Brice in the musical is supposed to be funny - to use your words, it’s right there in the book (in the title, even). It’s true that sometimes musical theatre uses music as a metaphorical stand-in for other forms of expression, but in Funny Girl, I don’t think that’s the case. Musical Fanny is funny AND a singer. And in my opinion, her humor is far more integral to her character, and the central theme of the show (“talent is beauty”), than her singing voice. The music, for me, is simply one of the ways in which she expresses that humor, and in the book scenes, the way she expresses her deepest emotion. And as long as someone is good enough at acting through song, that can be achieved without an amazing voice.
When Sheridan Smith sang the final verse of “People” after Nicky kisses her, it seemed like she was going to die of joy and the only medicine was to pour her heart into the song. True musical theatre in its purest form. I had tears in my eyes, and my heart was still pounding well into the next scene. And her singing was just ok.